Fix incorrectly rejected blocks #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assembly would reject blocks if an exact buffer was provided and no extra literals.
```
--- FAIL: TestEncoderRegression/best-c2-w16384k-1seg/054917b2373a9ca83257108e02e9c356e49d126f (0.02s)
encoder_test.go:257: error: output (40533) bigger than max block size (131072)
want: 829232
got: 786432
```
klauspost
commented
Apr 25, 2022
| @@ -1913,6 +1913,7 @@ error_not_enough_space: | |||
| MOVQ CX, 208(AX) | |||
| MOVQ 16(SP), CX | |||
| MOVQ CX, 216(AX) | |||
| MOVQ R12, 136(AX) | |||
There was a problem hiding this comment.
These showed up after re-regenerating.
klauspost
force-pushed
the
zstd-fix-bounds-blocks
branch
from
dc8513b
to
c11aad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly would reject blocks if an exact buffer was provided and no extra literals.