Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable assembly for more cases #559

Merged
merged 2 commits into from Apr 22, 2022
Merged

Enable assembly for more cases #559

merged 2 commits into from Apr 22, 2022

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Apr 21, 2022 •
edited

Fixes #561

@klauspost
Copy link
Owner Author

@WojciechMula PTAL. This should enable assembly in most cases.

@klauspost
Copy link
Owner Author 

2022-04-21T15:20:06.2905307Z === RUN   TestNewDecoderBad/DecodeAll/404a3a58fcbb8baf3912a6f3bff75bcec6e91b1f.zst
2022-04-21T15:20:06.2905540Z ==6560==ERROR: ThreadSanitizer failed to allocate 0x000030a00000 (815792128) bytes at 0x07c001800000 (error code: 1455)
2022-04-21T15:20:06.2905688Z FAIL	github.com/klauspost/compress/zstd	6.683s

This is the race runner failing to allocate. No biggie.

@WojciechMula
Copy link
Contributor

@klauspost Looks good. You did it so quick, I just started to look around the code :)

@klauspost klauspost mentioned this pull request Apr 22, 2022
Closed
@klauspost klauspost merged commit aa5b572 into master Apr 22, 2022
@klauspost klauspost deleted the use-sync-decoder-more branch April 22, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asm panic: runtime error: index out of range
2 participants
@klauspost @WojciechMula