huff0: Skip unneeded exhaust check #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not filling there is no reason to check if exhausted. ``` BenchmarkDecompress4XNoTable/gettysburg/10000-32 11867 11550 -2.67% BenchmarkDecompress4XNoTable/gettysburg/262143-32 336139 331035 -1.52% BenchmarkDecompress4XNoTable/twain/10000-32 11922 11561 -3.03% BenchmarkDecompress4XNoTable/twain/262143-32 387406 374386 -3.36% BenchmarkDecompress4XNoTable/pngdata.001/10000-32 12262 11961 -2.45% BenchmarkDecompress4XNoTable/pngdata.001/262143-32 319131 308746 -3.25% ```
|
@WojciechMula - Do you see any problems with this? |
No, that's fine! Thanks. |
|
Tried doing the same in the Go code, but it mostly led to slower performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not filling there is no reason to check if exhausted.