Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

huff0: Faster 1X Decompression #435

Merged
merged 3 commits into from Sep 2, 2021
Merged

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Sep 2, 2021

Go 1.17 compiler is weird.

@orijbot
Copy link

orijbot commented Sep 2, 2021

@klauspost klauspost merged commit 7bfeec6 into master Sep 2, 2021
@klauspost klauspost deleted the huff0-faster-decompression branch September 2, 2021 13:10
@odeke-em
Copy link

odeke-em commented Sep 2, 2021

You have some regressions, am not sure if you intended them or not https://dashboard.github.orijtech.com/benchmark/da0d1c1df2a54d3d8ffa6362d8cbc53e

We are working on making the bot an action so that it'll display the status for every commit and you can make required checks instead of manually inspecting always :-)

@klauspost
Copy link
Owner Author

klauspost commented Sep 2, 2021

@odeke-em All of these benchmarks are 100% unrelated. Most are compression benchmarks and this only changes decompression.

So I guess this gives an idea of the run-to-run variance. I am seeing the same locally with rather large compile-to-compile variance, especially after upgrading to Go 1.17. I know there isn't much you can do about that.

All of the CompressAllocations/EncodeAllDict65536_0/Encoder_EncodeAllHTML/WriterRandom/TwainEncode1e5/RandomEncodeBlock1MB/RandomEncodeBetterBlock16MB are in unrelated code, and it is of course sad that variance is >10% in some cases.

Only Decompress1X benchmarks should have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants