Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance baseline #434

Merged
merged 1 commit into from Sep 1, 2021
Merged

Add performance baseline #434

merged 1 commit into from Sep 1, 2021

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Sep 1, 2021

Disables stdlib tests.

@orijbot
Copy link

orijbot commented Sep 1, 2021

@odeke-em
Copy link

odeke-em commented Sep 1, 2021

@klauspost sorry for the confusion and thank you for using bencher! So after you merge this master, we'll finally have some baseline comparison values and then subsequent PRs will use that baseline :-) cc @cuonglm

@klauspost klauspost merged commit c608412 into master Sep 1, 2021
@klauspost klauspost deleted the baseline-perf branch September 1, 2021 15:53
@klauspost
Copy link
Owner Author

@odeke-em Yeah, there are literally hundreds of benchmarks in this package, so your system will get quite a workout.

Maybe I should make the non-important benchmarks be ignored by -test.short, so I can filter them a bit.

@odeke-em
Copy link

odeke-em commented Sep 1, 2021

Thanks for the notice @klauspost! Good point about using if testing.Short() As for the number of tests, it might take like 30+ minutes but the tests are running for example https://dashboard.github.orijtech.com/benchmark/f47cd13a3f1b4c5da331880af8f63adc

@odeke-em
Copy link

odeke-em commented Sep 1, 2021

@klauspost, now that you have the baseline data available, things should run smoothly. I also created my own fork of this repo and firstly started with a change in March 2020 orijtech@badde52 and from that used the current code on your master branch and this was the interesting result https://dashboard.github.orijtech.com/benchmark/ddfc52a0d5a743cf8b0f3785fb5e1ef0

Lots of improvements in pretty much all the benchmarks. However, some like RandomEncode, GzipL6, Encoder*, Deflate/, Decompress have regressed quite a lot since that commit in 2020
Screen Shot 2021-09-01 at 11 44 11 AM

cc also @kirbyquerby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants