Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clap version to 4.0 and switch to the Derive API #248

Merged
merged 2 commits into from Nov 14, 2022

Conversation

tranzystorekk
Copy link
Contributor

Hi, hope this isn't too big for a first contribution 馃檪

Should make the code a bit more readable with the Derive API.

Notes:

  • had to bump pest in Cargo.lock to resolve a dependency conflict
  • the extension flag now additionally accepts comma-delimited lists, e.g. -e strikethrough,table,footnotes
  • clap no longer adds author info by default, so I skipped it for now (adding it back is a bit involved)

@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented Nov 13, 2022

Seems we should somehow disable clap for wasm: lambda-fairy/rust-errno#21 (comment), or at least the wrap_help feature

@kivikakk
Copy link
Owner

Thank you so much, this is perfect, and certainly not too big at all! Really clear changes and very easy to review. Massively appreciated! 馃グ

@kivikakk kivikakk merged commit e9295ff into kivikakk:main Nov 14, 2022
@tranzystorekk tranzystorekk deleted the clap-v4 branch November 14, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants