New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of newline in inline code block #210
Conversation
Before this test failures were assigned to the location inside `compare_strs`. With the change the error is assigned to the actual call-site of the `html(A,B)` check.
Ugh, there is something trickier going on than I'd thought. |
1ef778f
to
c3c6707
Compare
The trouble I was having was actually with the round-trip tests, not where I thought it was. The cause ofmy confusion was that I didn't realise the Anyway, sorry about the delay on this. |
c52ab55
to
f6d6117
Compare
ta, this looks superb! I ran |
if you want a release with these changes, give us a shout, otherwise we'll just wait until there's more accumulated. |
No need for a new release. I'm happy to point my cargo at the commit for now. |
This case
`\n`
was getting parsed as<code></code>
rather than<code> </code>
due to the\n
getting flagged as a non-space character. Change is pretty simpleThere's actually an unrelated commit with this that changes error reporting to use
#[track_callers]
that makes test failures point to the right line (rather than inside thecompare_strings
helper function)I can break this into two PRs if you want -- but they seemed trivial enough to review together.