New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker base image & respect sonar-project.properties #20
Conversation
Noice, @jankal! 🔥 |
@dwisiswant0 thank you for checking back again. I found issues on line 17 of |
@dwisiswant0 now I think it's all fixed up :) But it might be a good idea to also test it on other projects first. |
Thanks for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible. |
Accepted! Thanks for your patience & contributions, wait to be merged. |
Description
As the title says, I updated the base image this image relies on so it now ueses SonarScanner v4.5. The image size might be accacted. I think, this is a non-issue bc GitHub handles pulling the image.
I also added logic to detect a
sonar-project.properties
file in the current directory. When one is present the config settings from that file are used instead of settings from GH Actions or auto-generated settings (likeprojectName
being the repo name).Related Issue
Fixes #5
Also updates Docker base image to Sonar-Scanner v4.5
Motivation and Context
The upstream docker image already dates back one year. I also hope to get rid of the node:8 warnings in SonarQube.
Types of Changes
New feature (non-breaking change which adds functionality)How Has This Been Tested?
I ran the action in one of my projects, where a
sonar-project.properties
file exists.See here.