Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker base image & respect sonar-project.properties #20

Merged
merged 3 commits into from Dec 29, 2020

Conversation

jankal
Copy link
Contributor

@jankal jankal commented Dec 17, 2020

Description

As the title says, I updated the base image this image relies on so it now ueses SonarScanner v4.5. The image size might be accacted. I think, this is a non-issue bc GitHub handles pulling the image.
I also added logic to detect a sonar-project.properties file in the current directory. When one is present the config settings from that file are used instead of settings from GH Actions or auto-generated settings (like projectName being the repo name).

Related Issue

Fixes #5
Also updates Docker base image to Sonar-Scanner v4.5

Motivation and Context

The upstream docker image already dates back one year. I also hope to get rid of the node:8 warnings in SonarQube.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

How Has This Been Tested?

I ran the action in one of my projects, where a sonar-project.properties file exists.

See here.

@kitabisa-bot
Copy link

kitabisa-bot bot commented Dec 17, 2020

Please consider taking a moment for us to review this pull request.

review needed

@dwisiswant0
Copy link
Member

Noice, @jankal! 🔥
We'll go back as soon for review.

entrypoint.sh Outdated Show resolved Hide resolved
@dwisiswant0
Copy link
Member

Hi, @jankal. Is c949545 passed test?

@jankal
Copy link
Contributor Author

jankal commented Dec 19, 2020

@dwisiswant0 thank you for checking back again. I found issues on line 17 of entrypoint.sh which I have to fix first. Do not merge.

@jankal
Copy link
Contributor Author

jankal commented Dec 19, 2020

@dwisiswant0 now I think it's all fixed up :)

But it might be a good idea to also test it on other projects first.

@kitabisa-bot
Copy link

kitabisa-bot bot commented Dec 21, 2020

Thanks for raising your pull request. Please make sure you have followed our contributing guidelines.

We will review it as soon as possible.

on hold

@kitabisa-bot
Copy link

kitabisa-bot bot commented Dec 29, 2020

Accepted! Thanks for your patience & contributions, wait to be merged.

@dwisiswant0 dwisiswant0 merged commit 9b52913 into kitabisa:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

projectKey not read from sonar-project.properties
2 participants