Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] Convert command button panel to the lazy world #11

Closed
kirill-grouchnikov opened this issue Jan 11, 2022 · 1 comment
Closed

[Component] Convert command button panel to the lazy world #11

kirill-grouchnikov opened this issue Jan 11, 2022 · 1 comment
Assignees
@kirill-grouchnikov
Labels
1.1 - Blizzard Release 1.1 - 2022.H1 Breaking change Marking changes that break backwards compatibility

Comments

@kirill-grouchnikov
Copy link
Owner

See https://developer.android.com/jetpack/compose/lists#lazy and https://developer.android.com/jetpack/compose/lists#grids
@kirill-grouchnikov kirill-grouchnikov added the 1.1 - Blizzard Release 1.1 - 2022.H1 label Jan 11, 2022
@kirill-grouchnikov kirill-grouchnikov self-assigned this Jan 11, 2022
@kirill-grouchnikov
Copy link
Owner Author

With lazy construction of content, the existing logic that computes the number of columns for RowFill and rows for ColumnFill needs to be changed since we're not going to be looking at the entire content ahead of time. Marking as breaking change.

@kirill-grouchnikov kirill-grouchnikov added the Breaking change Marking changes that break backwards compatibility label Jan 28, 2022
kirill-grouchnikov added a commit that referenced this issue Jan 29, 2022
@kirill-grouchnikov
Convert command button panel to the lazy world
201b8f9 
First pass for #11
kirill-grouchnikov added a commit that referenced this issue Jan 31, 2022
@kirill-grouchnikov
Configuration tweaks for popup menu panels
4582d80 
Add `CommandPopupMenuPanelPresentationModel` that is specifically targeting to configure the presentation of command panels embedded in command popup menus.

Update all the demos and the documentation.

This is part of #11
kirill-grouchnikov added a commit that referenced this issue Feb 1, 2022
@kirill-grouchnikov
Add spacing between buttons in button panels
edf3813 
For #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirill-grouchnikov kirill-grouchnikov

Labels
1.1 - Blizzard Release 1.1 - 2022.H1 Breaking change Marking changes that break backwards compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirill-grouchnikov