Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple equal ligatures rendered incorrectly in different font size. #141

Open
dsngo opened this issue May 24, 2020 · 2 comments
Open

Triple equal ligatures rendered incorrectly in different font size. #141

dsngo opened this issue May 24, 2020 · 2 comments
Labels

Comments

@dsngo
Copy link

dsngo commented May 24, 2020

Renders ligatures incorrectly

Ive recently been using operator-mono-lig to patch ligatures for Operator Font. On the default font size setting of vscode (which is 14px) the ligatures is rendered horrifically, especially the triple equal glyph. I have attached a photo of it.

I either have to change the fontsize to 11px or 16 whichpx is too small or too large to get over it. I never have this issue with Dank Mono or Fira Code. Is there anyone else having this issue?

The resolution Ive used is 1920x1080. Im using the lastest release of the patch and Operator SSm version.

@kiliman
Copy link
Owner

kiliman commented May 24, 2020

Sorry about that. Hinting is hard. It's even harder when you are patching an existing font vs building a new font like Fira Code or Dank Mono.

Glyphs with horizontal and vertical lines are especially difficult when you have a limited number of pixels available.

I use 16 px on a 4K screen so it wasn't an issue for me. I will try it out on different resolutions and pixel sizes to try and catch these early. Our resident designer @amitkparekh is in the process of redoing all the ligatures, so we'll pay closer attention to hinting.

Thanks for the report.

@kiliman kiliman added the bug label May 24, 2020
@dsngo
Copy link
Author

dsngo commented May 24, 2020

Hey, thanks a lot for replying. This definitely sounds great.
In the meantime, I think the optimal fontsize and resolution should be mentioned in the readme though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants