Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forked projects with different name not related with base repository are not being considered #157

Open
Ginxo opened this issue Jun 18, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@Ginxo
Copy link
Contributor

Ginxo commented Jun 18, 2021

We are considering forked projects:

  • the ones related with the base repository (appears on the forked project list)
  • the ones with the same name as the base repository

Still pending:

-the ones with the different name as the base repository and not related with it

@jsoref https://github.com/jsoref/ suggested a very interesting approach we should at least consider https://github.community/t/github-api-getting-fork-project-for-a-specific-user/185441/3?u=ginxo

@Ginxo
Copy link
Contributor Author

Ginxo commented Nov 3, 2021

wondering whether we should consider to treat this case... 🤔

@Ginxo Ginxo added the enhancement New feature or request label Nov 3, 2021
@mareknovotny
Copy link
Member

wasn't this already fixed in #156 ?

@jsoref
Copy link

jsoref commented Oct 11, 2023

Dunno :). Sadly GitHub didn't leave enough breadcrumbs for me to be able to recall what I suggested... -- it's likely my suggestion was to check to see if two commits were reachable for the same sha across the fork world (with the same content...), as generally github has treated connected repositories as a single repository. (Amusingly, github's current search engine currently treats identical individual documents from unrelated repositories as equivalent -- this is discernible today because the counts don't treat them as distinct when a search hits each of them...)

I will say that it's possible for a user to have:

  • a repository with the same name as your repository that isn't related
  • two (or presumably more, although I haven't managed to do this yet...) forks of your repository with other names (!!) -- please don't ask how, but I've managed to do it a couple of times of late, so apparently the naive assumption that I (and probably everyone else) had that there'd be at most one related fork per user is well, just that ...

@mareknovotny
Copy link
Member

so @jsoref to summarize you still have this issue with a repository not being considered, right?

@jsoref
Copy link

jsoref commented Oct 11, 2023

I don't think I use this action. I'm here because I use lots of repositories and was involved in GitHub's prototype community. I offered input based on a question and someone filed this issue and tagged me.

It should be easy enough to test to confirm...

@mareknovotny
Copy link
Member

ok, thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants