Code style updates #410
Merged
Code style updates #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lmansur Would be great to have your feedback on this if you have any time. |
|
Thanks for the ping, @grzuy. The PR looks good to me 👍. I think we are in the right path of establishing a Rubocop file and committing to it. Do you think it's worth setting up some kind of static code analysis (CodeClimate, Codacy, HoundCI, etc) as a PR check? It might be a good way of ensuring we don't have regressions on the code style. |
|
Thanks for the feedback! We do check for code style regressions on every PR already. TravisCI fails if rubocop fails since 1e9d601. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue what started in #330 and #338