We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I noticed this "tautological" if statement.... basically, it is doing if nil == nil because err is nil at this point:
if nil == nil
err
nil
https://github.com/kiali/kiali/blob/v1.84.0/tracing/jaeger/grpc_client.go#L38
This if-statement should be removed, unless I'm not understanding something in this code.
The text was updated successfully, but these errors were encountered:
+1, that if can be removed.
if
Sorry, something went wrong.
will wait for #7353 to get merged since this will conflict with the same code.
remove tautological if-stmt
ee3c4ca
fixes: kiali#7354
dada436
remove tautological if-stmt (#7380)
07d11db
fixes: #7354
jmazzitelli
Successfully merging a pull request may close this issue.
I noticed this "tautological" if statement.... basically, it is doing
if nil == nil
becauseerr
isnil
at this point:https://github.com/kiali/kiali/blob/v1.84.0/tracing/jaeger/grpc_client.go#L38
This if-statement should be removed, unless I'm not understanding something in this code.
The text was updated successfully, but these errors were encountered: