Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barely visible color choice for "Not Ready" icon in dark-mode #7317

Open
ishitharaj opened this issue Apr 27, 2024 · 7 comments
Open

Barely visible color choice for "Not Ready" icon in dark-mode #7317

ishitharaj opened this issue Apr 27, 2024 · 7 comments
Assignees
@Densentrated
Labels
enhancement This is the preferred way to describe new end-to-end features. good first issue Needs a contributor. Good starter issue

Comments

@ishitharaj
Copy link

Describe the bug

When you select dark-mode in Kiali, "Not Ready" icon barely visible. You have to have workloads in Not Ready state to see this.
Screenshot 2024-04-27 at 13 58 14

Expected Behavior

"Not Ready" icon is properly visible in both light/dark theme

What are the steps to reproduce this bug?

  1. Deploy Kiali and open UI
  2. Make sure that you have workloads in "Not Ready" state
  3. Change theme to dark mode and check workloads list. Icons are visible in Health column.

Environment

Learn about how to determine versions here.

  • Kiali version: 1.78
@ishitharaj ishitharaj added the bug Something isn't working label Apr 27, 2024
@ishitharaj
Copy link
Author

ishitharaj commented Apr 27, 2024 •
edited

Label should be [enhancement][good first issue]. Not a bug.

@jshaughn jshaughn added enhancement This is the preferred way to describe new end-to-end features. good first issue Needs a contributor. Good starter issue backlog Triaged Issue added to backlog and removed bug Something isn't working labels Apr 27, 2024
@Densentrated
Copy link

Hey! do you mind if I take this one on?

@ishitharaj
Copy link
Author

Hey! do you mind if I take this one on?

Sure.. No problem..

@jshaughn
Copy link
Collaborator

I think @Densentrated was asking the maintainers :-) But the answer is the same! Thanks!

@jshaughn jshaughn removed the backlog Triaged Issue added to backlog label Apr 29, 2024
@jshaughn
Copy link
Collaborator

Hi @Densentrated , any updates?

@Densentrated
Copy link

Hey!, I forgot that I had AP Tests the week after I asked to take this on, but now that they are over, I will be on top of this!

@jshaughn
Copy link
Collaborator

NP, hope the tests went well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Densentrated Densentrated

Labels
enhancement This is the preferred way to describe new end-to-end features. good first issue Needs a contributor. Good starter issue
Projects
Kiali Sprint 24-7 | Kiali v1.86
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jshaughn @ishitharaj @Densentrated