Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MavenProjectResult with more appropriate Information #187

Open
khmarbaise opened this issue Mar 8, 2021 · 0 comments
Open

Replace MavenProjectResult with more appropriate Information #187

khmarbaise opened this issue Mar 8, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@khmarbaise
Copy link
Owner

Is your feature request related to a problem? Please describe.
The current content of MavenProjectResult can be used in a beforeEach() (#177) method. But this in consequence means that the naming of MavenProjectResult is misleading. Apart from that there are some areas of the directory structures are missing:

      src/test/java/../
         +--- FirstIT.java
                +--- test_case_one
      src/test/resources-its/.../
         +--- FirstIT/
                 +--- test_case_one
                         +--- src/...
                         +--- pom.xml

Currently we have the following:

   target/maven-it/
      .../FirstIT
           +--- test_case_one            <-- targetBaseDirectory
                   +--- .m2/             <-- targetCacheDirectory
                   +--- project          <-- targetProjectDirectory
                           +--- src/
                           +--- pom.xml  <-- model
                   +--- mvn-stdout.log
                   +--- mvn-stderr.log

Describe the solution you'd like
We have to change the naming as well adding supplemental information from the source area as well:

target/maven-it/
  .../FirstIT
       +--- test_case_one            <-- targetBaseDirectory
               +--- .m2/             <-- targetCacheDirectory
               +--- project          <-- targetProjectDirectory
                       +--- src/
                       +--- pom.xml  <-- model (targetModel)
               +--- mvn-stdout.log
               +--- mvn-stderr.log

And for the source area:

src/test/java/../
   +--- FirstIT.java
          +--- test_case_one      <--- sourceBaseDirectory
src/test/resources-its/.../
   +--- FirstIT/
           +--- .predefined-repo  <--- sourceRepo (optional)
           +--- test_case_one     <--- sourceProjectDirectory
                   +--- src/...
                   +--- pom.xml    <--- sourceModel

Define two new classes which contain the appropriate information:

  • MavenTarget
    • baseDirectory, cacheDirectory, projectDirectory
  • MavenSource
    • baseDirectory, projectDirectory, repository (optional)

Furthermore we need to separate out the information about the model pom.xml and should not combine that with directory information.

  • MavenModelTarget
    • model (targetModel)
  • MavenModelSource
    • model (sourceModel)
@khmarbaise khmarbaise added the enhancement New feature or request label Mar 8, 2021
@khmarbaise khmarbaise self-assigned this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant