Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar in UI Admin List view doesn't work #2613

Closed
Tracked by #2692
justintemps opened this issue Mar 31, 2020 · 5 comments · Fixed by #2827
Closed
Tracked by #2692

Search bar in UI Admin List view doesn't work #2613

justintemps opened this issue Mar 31, 2020 · 5 comments · Fixed by #2827

Comments

@justintemps
Copy link
Contributor

justintemps commented Mar 31, 2020

Bug report

Describe the bug

The Search component in the UI Admin List View is unresponsive. When user attempts to interact with it, React throws the following error:

Warning: Cannot update a component (`Search`) while rendering a different component (`Search`).
To locate the bad setState() call inside `Search`, follow the stack trace as described in
https://fb.me/setstate-in-render

System information

This happens on MacOS Catalina Chrome. Current Keystone installs look like this

"@keystonejs/adapter-mongoose": "^5.2.1",
"@keystonejs/app-admin-ui": "^5.9.2",
"@keystonejs/app-graphql": "^5.1.2",
"@keystonejs/auth-password": "^5.1.2",
"@keystonejs/fields": "^7.0.0",
"@keystonejs/keystone": "^6.0.1",
@Vultraz
Copy link
Contributor

Vultraz commented Mar 31, 2020

Duplicate of #2419 I think.

@justintemps
Copy link
Contributor Author

@Vultraz That seems likely. Do you want me to close this? Slightly different error message here than in #2419 specifically as it relates to the component.

@Vultraz
Copy link
Contributor

Vultraz commented Apr 1, 2020

Ok, apparently the second warning ("Cannot update a component from inside...") was introduced in React 16.13.0. I've tracked it down to the useQuery call in useListQuery... Investigating. Turns out it's a separate issue from the Tooltip one, so leave this open for the Search problem.

@Vultraz
Copy link
Contributor

Vultraz commented Apr 1, 2020

Relevant: apollographql/react-apollo#3863

@Vultraz
Copy link
Contributor

Vultraz commented Apr 2, 2020

The more detailed error with React 16.13.1.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants