Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally run Quarkus IT in GHA based on code changes #29118

Closed
Tracked by #25931
vmuzikar opened this issue Apr 26, 2024 · 0 comments · Fixed by #29157
Closed
Tracked by #25931

Conditionally run Quarkus IT in GHA based on code changes #29118

vmuzikar opened this issue Apr 26, 2024 · 0 comments · Fixed by #29157
Assignees
Labels
area/dist/quarkus area/testsuite Indicates an issue on the Testsuite area kind/enhancement Categorizes a PR related to an enhancement release/25.0.0 team/cloud-native team/continuous-testing

Comments

@vmuzikar
Copy link
Contributor

vmuzikar commented Apr 26, 2024

Description

We should not need to run the Quarkus testsuite with each PR. Full testsuite needs to be executed only when code is changed in the quarkus module, or when the root pom.xml changes. This change should be safe enough. We run the base integration testsuite with Quarkus, so any code change in core Keycloak code base that breaks the Quarkus integration should be visible there.

Full testsuite should still run nightly in case something slips between the cracks.

Discussion

No response

Motivation

No response

Details

No response

@vmuzikar vmuzikar added area/testsuite Indicates an issue on the Testsuite area kind/enhancement Categorizes a PR related to an enhancement area/dist/quarkus labels Apr 26, 2024
@vmuzikar vmuzikar self-assigned this Apr 29, 2024
@vmuzikar vmuzikar changed the title Selectively run Quarkus IT in GHA based on code changes Conditionally run Quarkus IT in GHA based on code changes Apr 29, 2024
vmuzikar added a commit to vmuzikar/keycloak that referenced this issue Apr 29, 2024
Closes keycloak#29118

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
vmuzikar added a commit to vmuzikar/keycloak that referenced this issue Apr 29, 2024
Closes keycloak#29118

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
vmuzikar added a commit to vmuzikar/keycloak that referenced this issue May 3, 2024
Closes keycloak#29118

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
vmuzikar added a commit that referenced this issue May 7, 2024
Closes #29118

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dist/quarkus area/testsuite Indicates an issue on the Testsuite area kind/enhancement Categorizes a PR related to an enhancement release/25.0.0 team/cloud-native team/continuous-testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant