Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-build shouldn't warn about unavailable runtime options #28948

Closed
1 of 2 tasks
ahus1 opened this issue Apr 21, 2024 · 2 comments · Fixed by #29110
Closed
1 of 2 tasks

Auto-build shouldn't warn about unavailable runtime options #28948

ahus1 opened this issue Apr 21, 2024 · 2 comments · Fixed by #29110

Comments

@ahus1
Copy link
Contributor

ahus1 commented Apr 21, 2024

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

dist/quarkus

Describe the bug

When running Keycloak in auto-build mode, the Picoli class will show a warning when conditional runtime options are used.

Version

main

Regression

  • The issue is a regression

Expected behavior

No warnings in auto-build around unavailable runtime options, as the user can't really change what they are doing here, as in auto-build both runtime and non-runtime options are passed to the CLI.

Warnings should indicate something that the user should change (which they can't in this case)

Actual behavior

 (main) The following used run time options are UNAVAILABLE and will be ignored during build time:
        - cache-remote-tls-enabled: Available only when remote host is set.

How to Reproduce?

Note that first #28950 needs to be merged, then the following will reproduce it. AFAIK this is the first time a runtime option is making something conditional.

bin/kc.sh start --cache-remote-host=localhost --cache-remote-tls-enabled=false

Anything else?

This happens only when runtime options are the source of the conditional, as here with the --cache-remote-host.

@shawkins
Copy link
Contributor

~priority-normal

@keycloak-github-bot
Copy link

Due to the amount of issues reported by the community we are not able to prioritise resolving this issue at the moment.

If you are affected by this issue, upvote it by adding a 👍 to the description. We would also welcome a contribution to fix the issue.

@shawkins shawkins self-assigned this Apr 26, 2024
shawkins added a commit to shawkins/keycloak that referenced this issue Apr 26, 2024
closes: keycloak#28948

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
shawkins added a commit to shawkins/keycloak that referenced this issue Apr 26, 2024
closes: keycloak#28948

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
vmuzikar pushed a commit that referenced this issue May 2, 2024
closes: #28948

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants