Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the client name help grammatical error #29094

Closed
1 of 2 tasks
biya-bi opened this issue Apr 25, 2024 · 3 comments
Closed
1 of 2 tasks

Fix the client name help grammatical error #29094

biya-bi opened this issue Apr 25, 2024 · 3 comments

Comments

@biya-bi
Copy link

biya-bi commented Apr 25, 2024

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

admin/ui

Describe the bug

Hi,
This minor bug is to fix a small grammatical error noticed while creating a client from the admin UI. As can be noticed in the attached screenshot, the word "the" has been omitted before the words "display name". I think it might be better if the client name message is:

Specifies the display name of the client. For example 'My Client'. Supports keys for localized values as well. For example: ${my_client}

client_name_tooltip_grammatical_error

Version

24.0.4

Regression

  • The issue is a regression

Expected behavior

The client name help displayed while creating a client should display the below message:

Specifies the display name of the client. For example 'My Client'. Supports keys for localized values as well. For example: ${my_client}

Actual behavior

Currently, the client name help displayed while creating a client displays the below message. We can notice that the word "the" is missing between the word "Specifies" and the word "display":

Specifies display name of the client. For example 'My Client'. Supports keys for localized values as well. For example: ${my_client}

client_name_tooltip_grammatical_error

How to Reproduce?

On the admin UI, try to create a client. Once on the General settings page, click on the question mark beside the Name label.

Anything else?

No response

@biya-bi
Copy link
Author

biya-bi commented Apr 25, 2024

I will submit a pull request for this issue.

@keycloak-github-bot
Copy link

Due to the amount of issues reported by the community we are not able to prioritise resolving this issue at the moment.

If you are affected by this issue, upvote it by adding a 👍 to the description. We would also welcome a contribution to fix the issue.

jonkoops pushed a commit that referenced this issue May 3, 2024
Closes #29094

Signed-off-by: Paul Muriel Biya-Bi <paulmuriel.biyabi@gmail.com>
@edewit
Copy link
Contributor

edewit commented May 6, 2024

pr merged closing

@edewit edewit closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants