Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tomcat and Jetty servers from the test suite #29114

Merged
merged 1 commit into from Apr 30, 2024

Conversation

douglaspalmer
Copy link
Contributor

@douglaspalmer douglaspalmer commented Apr 26, 2024

Closes #29089

Closes keycloak#29089

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonkoops jonkoops changed the title 29089 Remove Tomcat and Jetty servers from the test suite Apr 26, 2024
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@douglaspalmer @miquelsi Thanks, I am approving as from my point of view, it should be good. But before merging, I would rather ask also @miquelsi (or someone from the QA team) for the review.

@miquelsi This PR does not remove any EAP, Fuse or SpringBoot bits from the testsuite, but just tomcat and Jetty stuff. Is it ok to merge this one?

@mposolda mposolda requested a review from miquelsi April 26, 2024 16:21
@jonkoops jonkoops added the status/hold PR should not be merged. On hold for later. label Apr 26, 2024
@miquelsi
Copy link
Contributor

For Jetty I'm totally fine with removing it, we don't test it for long now.

However, we're still using Tomcat for testing the Springboot adapters. Since the plan for testing those adapters is still being discussed, we might want to keep it still. Although we can still test those adapters with Undertow. If this option is acceptable, I'm fine removing Tomcat too.

WDYT, @mposolda?

@mposolda
Copy link
Contributor

@miquelsi Yes, I think it is. Also we are going to test SpringBoot with the RH-SSO testsuite as discussed in the meetings, so we should be ok with removing tomcat and jetty.

@mposolda mposolda merged commit 8d4d5c1 into keycloak:main Apr 30, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant servers from the testsuiite
4 participants