New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not able to disable declarative_ui feature #29057
Comments
@jonkoops this seems to be a admin ui issue to me, and not a core issue? |
Well i'm not aware of the boundaries of the project, what i could figure maybe the way of applying the feature flag is not ok: both relying on SPI.isEnabled() I found 1 occurence of checking spi.isEnabled() in org.keycloak.services.DefaultKeycloakSessionFactory#init keycloak/services/src/main/java/org/keycloak/services/DefaultKeycloakSessionFactory.java Line 100 in a3f2ebb
and org.keycloak.quarkus.runtime.integration.QuarkusKeycloakSessionFactory#init Line 96 in 168734b
overrides this so i believe spi.isEnabled() not being checked when QuarkusKeycloakSessionFactory is being used But i haven't checked this with debugger. Or maybe something else - please feel free to validate my assumptions. |
Due to the amount of issues reported by the community we are not able to prioritise resolving this issue at the moment. If you are affected by this issue, upvote it by adding a 👍 to the description. We would also welcome a contribution to fix the issue. |
Hmmm, yeah looks like a missing condition somewhere. @edewit could you take a look at this? |
fixes: keycloak#29057 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
fixes: #29057 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Before reporting an issue
Area
admin/ui
Describe the bug
The DECLARATIVE_UI feature extendable admin console could not be turned off.
Referring to this recently added feature:
#23772
I was trying out the introduced feature based on this quickstart:
https://github.com/keycloak/keycloak-quickstarts/tree/latest/extension/extend-admin-console-spi
once i have the extend-admin-ui,jar in the providers folder the attempt to disable the extension seems failing.
see the attached screenshots one with enabled one with disabled. ("todo" item is visible on the left regardless of the setting)
Maybe i got it wrong but i thought that it is possible to switch off this experimental feature.
Version
24.0.3
Regression
Expected behavior
when i set declarative_ui disabled the UI elements should not be visible
Actual behavior
when i set declarative_ui disabled the UI elements are visible
How to Reproduce?
deploy the above mentioned quickstart ( https://github.com/keycloak/keycloak-quickstarts/tree/latest/extension/extend-admin-console-spi )
to disable i added the "declarative_ui" to this envvar KC_FEATURES_DISABLED
then kc.sh build
Anything else?
No response
The text was updated successfully, but these errors were encountered: