Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific events for webauthn register #10114

Open
cbontemps opened this issue Feb 10, 2022 · 3 comments · May be fixed by #29028
Open

Specific events for webauthn register #10114

cbontemps opened this issue Feb 10, 2022 · 3 comments · May be fixed by #29028
Labels
area/authentication/webauthn kind/enhancement Categorizes a PR related to an enhancement

Comments

@cbontemps
Copy link

cbontemps commented Feb 10, 2022

Description

Keycloak currently emit specific events for "update password" and "update OTP" but not for "webauthn register" and "webauthnpasswordless register".

The use case is to send the user an email when a new WebAuthn authenticator is registered on his own account.

What the email template could be : "A WebAuthn authenticator was registered on {0} from {1}. If this was not you, please contact an administrator."

see https://issues.redhat.com/browse/KEYCLOAK-17175

Discussion

No response

Motivation

Currently, WebAuthn register events are mixed in type "custom_required_action" which makes them difficult to identify and handle.

Details

No response

@cbontemps cbontemps added kind/enhancement Categorizes a PR related to an enhancement status/triage labels Feb 10, 2022
@mabartos
Copy link
Contributor

mabartos commented Feb 10, 2022

@cbontemps Thanks for creating this issue. I like it! I think it makes sense to have a possibility to distinguish the events properly, as WebAuthn will be maintained in Keycloak for a long time and is included there by default. It'd be probably good to have even 'remove' events for that? @mposolda WDYT?

@mposolda
Copy link
Contributor

mposolda commented Mar 11, 2022

@mabartos Sorry for late answer. My vote is to rather have more generic event types like:
EventType=UPDATE_CREDENTIAL, details { credential_type=password }
or
EventType=UPDATE_CREDENTIAL, details { credential_type=webauthn }
or
EventType=UPDATE_CREDENTIAL, details { credential_type=webauthn-passwordless } .

Custom types for each credential doesn't work well with custom 2nd-factor credential types and will require some changes with each type introduced. But it is not a problem if credential has it's own way to add some additional details (Like EG. "attestation_statement" related details in the case of WebAuthn).

So ideal will be to rather remove types like UPDATE_PASSWORD or UPDATE_TOTP and replace them with something more generic. Same for REMOVE_TOTP for example

@mabartos
Copy link
Contributor

@mposolda Thanks for your comment. It makes sense.

resah added a commit to bare-id/keycloak that referenced this issue Mar 19, 2024
resah added a commit to bare-id/keycloak that referenced this issue Apr 16, 2024
resah added a commit to bare-id/keycloak that referenced this issue Apr 23, 2024
resah added a commit to bare-id/keycloak that referenced this issue Apr 23, 2024
resah added a commit to bare-id/keycloak that referenced this issue Apr 23, 2024
resah added a commit to bare-id/keycloak that referenced this issue Apr 23, 2024
closes keycloak#10114

Signed-off-by: Theresa Henze <theresa.henze@bare.id>
resah added a commit to bare-id/keycloak that referenced this issue Apr 23, 2024
Closes keycloak#10114

Signed-off-by: Theresa Henze <theresa.henze@bare.id>
@resah resah linked a pull request Apr 23, 2024 that will close this issue
resah added a commit to bare-id/keycloak that referenced this issue Apr 24, 2024
Closes keycloak#10114

Signed-off-by: Theresa Henze <theresa.henze@bare.id>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/authentication/webauthn kind/enhancement Categorizes a PR related to an enhancement
Projects
Status: 📤 Todo
Development

Successfully merging a pull request may close this issue.

3 participants