Update to OkHttp 4.10.0 #16383
Merged
Update to OkHttp 4.10.0 #16383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stianst
commented
Jan 11, 2023
stianst
force-pushed
the
update-okhttp3
branch
3 times, most recently
from
863dda8
to
38c3397
Compare
stianst
force-pushed
the
update-okhttp3
branch
from
38c3397
to
2cf317c
Compare
vmuzikar
previously approved these changes
Jan 12, 2023
There was a problem hiding this comment.
LGTM but this comes with some caveats.
With okhttp4 we're dragging in kotlin dependencies. For that reason, Quarkus is pushing back on this which might cause issues in native (that is not relevant to us at the moment). Once they get rid of okhttp dependency, we can remove this override.
pom.xml
Outdated
| <dependency> | ||
| <groupId>com.squareup.okhttp3</groupId> | ||
| <artifactId>okhttp</artifactId> | ||
| <version>4.10.0</version> |
There was a problem hiding this comment.
Should we perhaps use a property instead of a hardcoded version?
|
jFYI – this also concerns the Operator. Related issue: quarkiverse/quarkus-operator-sdk#448 |
stianst
force-pushed
the
update-okhttp3
branch
from
2cf317c
to
db65517
Compare
stianst
force-pushed
the
update-okhttp3
branch
from
db65517
to
1e86a0e
Compare
vmuzikar
approved these changes
Jan 12, 2023
stianst
added a commit
to stianst/keycloak
that referenced
this pull request
Jan 12, 2023
stianst
added a commit
to stianst/keycloak
that referenced
this pull request
Jan 12, 2023
stianst
added a commit
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16380