Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix classpath separator for windows startup script #15300

Merged
merged 2 commits into from Nov 7, 2022
Merged

Fix classpath separator for windows startup script #15300

merged 2 commits into from Nov 7, 2022

Conversation

Eng-Fouad
Copy link
Contributor

Fixes #15281

@johgoe
Copy link

johgoe commented Nov 2, 2022

2 Minutes faster than me :-)

lgtm

@stianst stianst mentioned this pull request Nov 3, 2022
Closed
@vmuzikar vmuzikar requested a review from Pepo48 November 3, 2022 13:46
vmuzikar
vmuzikar approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, trying to re-trigger the CI (again) to get a green on all required actions (previous failures were unrelated).

@stianst stianst merged commit 316479f into keycloak:main Nov 7, 2022
stianst added a commit to stianst/keycloak that referenced this pull request Nov 7, 2022
@Eng-Fouad @stianst
Fix classpath separator for windows startup script (keycloak#15300)
18059ed 
Closes keycloak#15281

Co-authored-by: Stian Thorgersen <stianst@gmail.com>
@stianst stianst mentioned this pull request Nov 7, 2022
Closed
stianst added a commit that referenced this pull request Nov 7, 2022
@stianst @Eng-Fouad
Fix classpath separator for windows startup script (#15300) (#15377)
6bab737 
Closes #15281

Co-authored-by: Stian Thorgersen <stianst@gmail.com>

Co-authored-by: Fouad Almalki <me@fouad.io>
@Eng-Fouad Eng-Fouad deleted the patch-1 branch November 7, 2022 20:13
RuslanTM pushed a commit to RuslanTM/keycloak that referenced this pull request Nov 9, 2022
@Eng-Fouad @stianst @RuslanTM
Fix classpath separator for windows startup script (keycloak#15300)
371e963 
Closes keycloak#15281

Co-authored-by: Stian Thorgersen <stianst@gmail.com>
andre-nascimento6791 pushed a commit to andre-nascimento6791/keycloak-cnd-work that referenced this pull request Dec 1, 2022
@Eng-Fouad @stianst @andre-nascimento6791
Fix classpath separator for windows startup script (keycloak#15300)
c8de20a 
Closes keycloak#15281

Co-authored-by: Stian Thorgersen <stianst@gmail.com>
@stianst stianst mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stianst stianst stianst approved these changes

@Pepo48 Pepo48 Pepo48 approved these changes

@vmuzikar vmuzikar vmuzikar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kc.bat fails with ClassNotFoundException
5 participants
@Eng-Fouad @johgoe @stianst @Pepo48 @vmuzikar