fix(sec): upgrade org.apache.tomcat:tomcat-catalina to 8.5.76 #14950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstractj
added
area/dependencies
kind/cve
abstractj
force-pushed
the
oscs_fix_cd718g8au51q1alfu0ug
branch
from
52d343f
to
876d10b
Compare
|
@stianst would be possible to include this change into 20.0.0? |
abstractj
previously approved these changes
Oct 21, 2022
martin-kanis
suggested changes
Oct 24, 2022
There was a problem hiding this comment.
I don't see a problem with upgrade of the version. However, there is one override of Tomcat version in the testsuite that can be removed with the PR. https://github.com/keycloak/keycloak/blob/main/testsuite/integration-arquillian/servers/pom.xml#L52
|
@Super-Sky could you please incorporate the changes requested by @martin-kanis ? |
stianst
approved these changes
Oct 25, 2022
|
Removed the override in the testsuite pom |
martin-kanis
approved these changes
Oct 25, 2022
andre-nascimento6791
pushed a commit
to andre-nascimento6791/keycloak-cnd-work
that referenced
this pull request
Dec 1, 2022
…ak#14950) Co-authored-by: stianst <stianst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened？
There are 8 security vulnerabilities found in org.apache.tomcat:tomcat-catalina 8.5.38
What did I do？
Upgrade org.apache.tomcat:tomcat-catalina from 8.5.38 to 8.5.76 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS