Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote new admin console to default #13243

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

stianst
Copy link
Contributor

@stianst stianst commented Jul 21, 2022

Documentation updates: keycloak/keycloak-documentation#1623

Closes #13242

@stianst stianst marked this pull request as draft July 21, 2022 10:56
@stianst stianst force-pushed the new-admin-default branch 3 times, most recently from 273a888 to 919717f Compare July 25, 2022 10:14
@stianst stianst marked this pull request as ready for review July 26, 2022 12:14
Copy link
Contributor

@ssilvert ssilvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stianst LGTM.

I assume that this was also discussed with QA team and the pipeline runs for admin console tests are somehow updated

@stianst
Copy link
Contributor Author

stianst commented Jul 26, 2022

@stianst LGTM.

I assume that this was also discussed with QA team and the pipeline runs for admin console tests are somehow updated

Good point, forgot that those tests run in the internal pipeline. We'll need some plan for this for sure, but perhaps we can sort this out after the release.

@miquelsi since we're trying to get the release out the door, would it be okay if we break the admin tests in the pipeline for now? Not sure if we should just get rid of the tests of for the old admin console now, or tweak the pipeline to enable the old admin console to continue testing that?

@stianst stianst requested a review from miquelsi July 26, 2022 14:41
@vmuzikar
Copy link
Contributor

Just to chime in. I think the "fix" for the old console tests should be fairly simple. Just enable/disable relevant features or change the used theme at the AbstractConsoleTest level.

@stianst stianst merged commit ae33af9 into keycloak:main Jul 27, 2022
@stianst stianst deleted the new-admin-default branch December 5, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote new admin console to default
4 participants