Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerable to Infinite Loop via malformed MKV file through file-type package #100

Open
qooban opened this issue Jul 26, 2022 · 4 comments
Open

Comments

@qooban
Copy link

qooban commented Jul 26, 2022

The following report is provided by NPM audit when using the latest version of decompress package (v4.2.1):

file-type  <16.5.4
Severity: moderate
file-type vulnerable to Infinite Loop via malformed MKV file - https://github.com/advisories/GHSA-mhxj-85r3-2x55

node_modules/decompress-tar/node_modules/file-type
node_modules/decompress-tarbz2/node_modules/file-type
node_modules/decompress-targz/node_modules/file-type
node_modules/decompress-unzip/node_modules/file-type
  decompress-tar  >=4.0.0

  Depends on vulnerable versions of file-type
  node_modules/decompress-tar
  decompress-tarbz2  >=4.0.0

  Depends on vulnerable versions of file-type
  node_modules/decompress-tarbz2
    decompress  >=4.0.0
    Depends on vulnerable versions of decompress-tarbz2
    node_modules/decompress

  decompress-targz  >=4.0.0
  Depends on vulnerable versions of file-type
  node_modules/decompress-targz
  
  decompress-unzip  >=4.0.1
  Depends on vulnerable versions of file-type
  node_modules/decompress-unzip

More description about the problem is provided here: GHSA-mhxj-85r3-2x55

The fix was implemented in file-type v16.5.4, so probably file-type should just be bumped in sub-packages: decompress-tar, decompress-tarbz2, decompress-targz, decompress-unzip.

@alfaproject
Copy link

@sindresorhus any chance you could give some security love to this package? <3

@UdayKumarNettem
Copy link

@sindresorhus @kevva : When can we expect the file-type vulnerability fix?

GHSA-mhxj-85r3-2x55.

https://nvd.nist.gov/vuln/detail/CVE-2022-36313

sonarqube-scanner@2.8.2
└─┬ decompress@4.2.1
└─┬ decompress-unzip@4.0.1
└── file-type@3.9.0

@UdayKumarNettem
Copy link

@qooban @alfaproject : How do you resolve this issue?

@qooban
Copy link
Author

qooban commented Nov 17, 2022

@UdayKumarNettem I don't have a solution for that. I provided my findings in the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants