Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_post_data_parameters doesn't filter out parameters with non-ASCII chars #686

Open
ubalklen opened this issue Mar 13, 2023 · 0 comments

Comments

@ubalklen
Copy link

import requests
import vcr

url = "http://www.iana.org/domains/reserved"

# Password will be visible in the cassette
with vcr.use_cassette("bugged_vcr.yaml", filter_post_data_parameters=["api:key"]):
    requests.post(url, data={"api:key": "SuperSecretP@ssword"})

# Works if I preemptively do the percentage encoding myself
with vcr.use_cassette("ok_vcr.yaml", filter_post_data_parameters=["api%3Akey"]):
    requests.post(url, data={"api:key": "SuperSecretP@ssword"})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant