Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: attest provenance for images #3421

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

prakrit55
Copy link
Member

  • added provenance mode to max for images

Fixes #3310

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

@prakrit55 prakrit55 requested a review from a team as a code owner April 15, 2024 13:00
@github-actions github-actions bot added the ops label Apr 15, 2024
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (0f38104) to head (23c1841).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3421   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files         167      167           
  Lines        7415     7415           
=======================================
  Hits         6326     6326           
  Misses        800      800           
  Partials      289      289           
Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <ø> (ø)
lifecycle-operator 83.42% <ø> (ø)
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies
Copy link
Member

mowies commented Apr 15, 2024

@prakrit55 please do a release in your fork with your own container registry to prove that this works :)
The release pipeline can be pretty fragile so it would be good to thoroughly test this before it's merged

@prakrit55
Copy link
Member Author

@prakrit55 please do a release in your fork with your own container registry to prove that this works :) The release pipeline can be pretty fragile so it would be good to thoroughly test this before it's merged

the job build-release in release please workflow is skipping, do I need to check anything else

@odubajDT
Copy link
Contributor

@prakrit55 please do a release in your fork with your own container registry to prove that this works :) The release pipeline can be pretty fragile so it would be good to thoroughly test this before it's merged

the job build-release in release please workflow is skipping, do I need to check anything else

Hi @prakrit55 you need to start the release workflow manually either by starting it from the Github actions or by merging the release-please PR which was automatically created o your fork

@prakrit55
Copy link
Member Author

Screenshot (300)
hey @odubajDT, not sure, if its the right step but it was skipping from the first, I modified and ran the workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate and attest provenance for images
3 participants