Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Keptn Cert Manager coverage #3038

Open
3 tasks
RealAnna opened this issue Feb 13, 2024 · 7 comments · May be fixed by #3143
Open
3 tasks

Increase Keptn Cert Manager coverage #3038

RealAnna opened this issue Feb 13, 2024 · 7 comments · May be fixed by #3143
Assignees
@YashPimple
Labels
good first issue Good for newcomers status: in-progress tests

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Feb 13, 2024 •
edited

Add unit tests to increase coverage of the cert-manager operator in Keptn. Specifically, improve coverage for the following files:

Ideally, code cov for the package should reach 70%.
@RealAnna RealAnna added good first issue Good for newcomers status: ready-for-refinement Issue is relevant for the next backlog refinment tests labels Feb 13, 2024
@odubajDT odubajDT removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Feb 14, 2024
@Bharadwajshivam28
Copy link
Contributor

Hello @RealAnna I have implemented unit test before can i work on this? as I am a new contributor also

@Bharadwajshivam28
Copy link
Contributor

Bharadwajshivam28 commented Feb 15, 2024 •
edited

Just I have few small doubts that are-

  1. There are already test written for the files you mentioned so do i need to modify it to increase coverage and how and where can i see the coverage %
  2. Do i need to fulfill prerequisites to check coverage % ?

@mowies mowies changed the title Increase Keptn Cert Manager converage Increase Keptn Cert Manager coverage Feb 15, 2024
@mowies
Copy link
Member

mowies commented Feb 15, 2024

please finish your other issue first :)

@YashPimple
Copy link
Member

Hi @RealAnna, I'd like to take this up!

@RealAnna
Copy link
Contributor Author

@YashPimple since you have no open PR I will assign you 🚀

@odubajDT
Copy link
Contributor

Hi @YashPimple any updates on this issue?

@YashPimple
Copy link
Member

Yes @odubajDT, I'm working on it and plan to submit a pull request within the next couple of days.

@YashPimple YashPimple linked a pull request Feb 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YashPimple YashPimple

Labels
good first issue Good for newcomers status: in-progress tests
Projects
Keptn Lifecycle Toolkit
Status: 🏃 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: enhance test coverage for keptn-cert-manager YashPimple/lifecycle-toolkit
5 participants
@mowies @RealAnna @odubajDT @YashPimple @Bharadwajshivam28