Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enhance test coverage for keptn-cert-manager #3143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: enhance test coverage for keptn-cert-manager #3143

wants to merge 2 commits into from

Conversation

YashPimple
Copy link
Member

@YashPimple YashPimple commented Feb 28, 2024 •
edited

Description

This PR aims to improve the test coverage of Keptn-cert-manager components
Fixes #3038

Coverage Summary:

eventfilter: 60.0% of statements
kubeutils: 69.7% of statements
pkg/certificates: 73.1% of statements

@YashPimple YashPimple requested a review from a team as a code owner February 28, 2024 14:12
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (32f077a) to head (0715437).

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #3143       +/-   ##
===========================================
- Coverage   85.33%   75.16%   -10.17%     
===========================================
  Files         167       76       -91     
  Lines        7412     4232     -3180     
===========================================
- Hits         6325     3181     -3144     
- Misses        799      820       +21     
+ Partials      288      231       -57

see 106 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 73.88% <ø> (+4.65%) ⬆️
component-tests 58.77% <ø> (+0.73%) ⬆️
lifecycle-operator ?
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

odubajDT
odubajDT previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@odubajDT
Copy link
Contributor

odubajDT commented Mar 6, 2024

@YashPimple can you please adapt your PR according to @RealAnna requests?

@YashPimple
Copy link
Member Author

@YashPimple can you please adapt your PR according to @RealAnna requests?

@odubajDT Yes currently working on it and will make the commits in couples of days

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@odubajDT
Copy link
Contributor

Hi @YashPimple any updates on this?

@YashPimple
Copy link
Member Author

Hi @YashPimple any updates on this?

@odubajDT i have prior only made the suggested changes in the above force commit

@odubajDT
Copy link
Contributor

odubajDT commented Apr 2, 2024

@YashPimple please see this

@odubajDT odubajDT mentioned this pull request Apr 9, 2024
Open
@odubajDT
Copy link
Contributor

@YashPimple ny updates on this please ?

@YashPimple
Copy link
Member Author

@YashPimple ny updates on this please ?

Yes will update the required changes by the EOD and will keep you updated on it.

@YashPimple
Copy link
Member Author

@odubajDT I have updated the above test function name as suggested.

@YashPimple
fix: failed checks
695e0fa 
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
@YashPimple
fix: failed unit test
0715437 
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT Awaiting requested review from odubajDT

@RealAnna RealAnna Awaiting requested review from RealAnna

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
cert-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase Keptn Cert Manager coverage
3 participants
@YashPimple @odubajDT @RealAnna