adding reviewed by section in the blogs and header details in the posts. #43
Conversation
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
There was a problem hiding this comment.
Hey @Aditya-eddy this blog post page needs several adjustments
- The author and reviewer boxes at the bottom need to match the previous styling with added padding and consistent font colors for the Heading.
- The label in the reviewer box also displays "AUTHOR DETAILS"; this should be changed to reflect the reviewer's information.
- the view more button is missing now please add the button within the author and reviewer detail boxes for enhanced navigation.
- Remove the hover animation on these detail boxes, as they are not interactive elements.
components/ReviewingAuthor.tsx
Outdated
| </button> | ||
| )} | ||
| </div> | ||
| {/* {authorLinkedIn !== "n/a" && ( |
There was a problem hiding this comment.
you can remove this commented code if it is not required
There was a problem hiding this comment.
fixed all the changes.
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
There was a problem hiding this comment.
@Aditya-eddy I see there are layout issues on the author image and whitespace left under it. Also, the design of the pop-up box on hovering the author needs to improve.
Hey @nehagup I am working on it! |
|
Hey @nehagup Does this look good: |
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
|
hey @Aditya-eddy can you resolve the conflicts ? |
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
|
Hey @Sonichigo I have resolved the conflicts please tell me where can we improve the contents of pr. Also any new feature for this pr that you are suggesting? |
|
@Aditya-eddy this has build issues |
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
There was a problem hiding this comment.
Thanks for the PR @Aditya-eddy, couple of changes are required to merge this.
- The written by, socials and mins read should be centre aligned vertically on a straight line. Also please make the profile and text as single liner, say, "Written by Animesh Pathak"
- Reviewer on all blogs would be my profile only.
- Please add the reviewed by section on tech blogs as well
- For the blogs that I have written (user id - neha) please add reviewed by Shubham.
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
|
Hey @nehagup i have made all the changes and the preview looks like this is this okay? Please give your feedback on this! |
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
There was a problem hiding this comment.
@Aditya-eddy Build is failing Type error: Cannot find module './SharingComponent' or its corresponding type declarations.
7 | import Image from "next/image";
8 | import PostHeaderAuthors from "./PostHeaderAuthors";
9 | import SharingComponent from "./SharingComponent";
| ^
10 | export default function PostHeader({
11 | title,
12 | coverImage,
Also please go through the comments
components/PostHeaderAuthors.tsx
Outdated
| sethoverStateBlogReviewer(true); | ||
| }; | ||
|
|
||
| const onmouseleaveBlogReviewer = () => { |
There was a problem hiding this comment.
Please use consistent camel case
| <> | ||
| <div className="max-w-9xl mx-auto bg-slate-000 shadow-md rounded-lg overflow-hidden flex flex-col sm:flex-row md:flex-row lg:flex-row"> | ||
| <div className="w-3/5 self-center sm:w-1/4 p-8 flex justify-center items-center"> | ||
| {avatar !== "n/a" && ( |
There was a problem hiding this comment.
why you are not using a ternary operator here? Is there any specific reason, if not use ternary operator so that there will be no code repetition
| @@ -52,6 +56,11 @@ export default function PostBody({ content, authorName }) { | |||
| '<div id="author-description-placeholder"></div>' // Placeholder for AuthorDescription | |||
| ); | |||
|
|
|||
| replacedContentWithAuthorDescription = | |||
| replacedContentWithAuthorDescription.replace( | |||
There was a problem hiding this comment.
can you please explain this part why you have done this?
There was a problem hiding this comment.
It's captures the class for removing default author part in the blog which comes with wordpress data.
pages/community/[slug].tsx
Outdated
| const blogwriter = [ | ||
| { | ||
| name: post?.ppmaAuthorName || "Unknown Author", | ||
| ImageUrl: avatarImgSrc, |
There was a problem hiding this comment.
please ensure that fallback is added for all the values
There was a problem hiding this comment.
I have added the fallback values in both the slugs for the community and technology.
pages/community/[slug].tsx
Outdated
| if (post && post?.content) { | ||
| const tempDiv = document.createElement("div"); | ||
| tempDiv.innerHTML = post?.content; | ||
| const avatarImgElement = tempDiv.querySelector( |
There was a problem hiding this comment.
why is this required can it be done by some other way because if there will be any change in the class it will break, we can't rely on query selector value
There was a problem hiding this comment.
Okay for that purpose I have used regex now!
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
fixes #issue
Attaching Screenshots: