Skip to content
This repository has been archived by the owner on Feb 20, 2020. It is now read-only.

not using all of eslint conf #1

Closed
bsr203 opened this issue Jan 13, 2017 · 3 comments
Closed

not using all of eslint conf #1

bsr203 opened this issue Jan 13, 2017 · 3 comments

Comments

@bsr203
Copy link

bsr203 commented Jan 13, 2017

Hi Kent,
thanks for releasing the plugin.

Let me brief about the behavior.
Installed the plugin.
On format with prettier-eslint-atom, it does format with prettier, but not follows eslint rules. I still have eslint warning about object-curly-spacing, which allow me to fix (auto fix on nuclide save file).
I use airbnb eslint config.
I previously also installed prettier plugin and I could see there is some difference in formatting between prettier and prettier-eslint-atom, so it may be using eslint config. But not sure why not object-curly-spacing, and others which can be auto fixed by eslint/nuclide plugin.

bsr.

@kentcdodds
Copy link
Owner

kentcdodds commented Jan 13, 2017

Hmmm... Could you do some investigation into why this is happening and maybe makeapullrequest.com?

@bsr203
Copy link
Author

bsr203 commented Jan 13, 2017

sorry not providing much info, thought it might easy to see in your test env. will try. until, this is solved, won't be using this plugin. so may take a while to get around looking at this.

@kentcdodds
Copy link
Owner

This should be resolved now. Please let me know if you still have trouble :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants