Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check prettier formatting in validate script #64

Open
alexkrolick opened this issue Sep 3, 2018 · 1 comment · May be fixed by #65 or #146
Open

check prettier formatting in validate script #64

alexkrolick opened this issue Sep 3, 2018 · 1 comment · May be fixed by #65 or #146

Comments

@alexkrolick
Copy link

alexkrolick commented Sep 3, 2018 •
edited

Without this, formatting is not checked in CI and only applied if the precommit hooks are installed, which is optional

Options:

  • Add prettier --list-different to validate command
  • Integrate prettier rules into ESLint (probably preferred for JS)
@alexkrolick alexkrolick changed the title Add prettier --list-different to validate commands check prettier formatting in validate script Sep 3, 2018
@kentcdodds
Copy link
Owner

Hmmm... I think it works already to do:

kcd-scripts format --list-different

alexkrolick added a commit to alexkrolick/kcd-scripts that referenced this issue Sep 3, 2018
@alexkrolick
add format check to validate
47eb836 
Fixes kentcdodds#64
@alexkrolick alexkrolick linked a pull request Sep 3, 2018 that will close this issue
Open
4 tasks
@MichaelDeBoey MichaelDeBoey linked a pull request May 24, 2020 that will close this issue
Open
@chriswrightdesign chriswrightdesign mentioned this issue Jan 10, 2023
Open
@chriswrightdesign chriswrightdesign mentioned this issue Dec 19, 2023
Open
@chriswrightdesign chriswrightdesign mentioned this issue May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kentcdodds @alexkrolick