Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prettier): jsxBracketSameLine -> bracketSameLine #230

Merged
merged 1 commit into from Aug 24, 2022

Conversation

nickmccurdy
Copy link
Contributor

@nickmccurdy nickmccurdy commented Aug 24, 2022

What: Rename jsxBracketSameLine to bracketSameLine

Why: Prettier prints deprecation warnings when using jsxBracketSameLine

This release renames the jsxBracketSameLine option to bracketSameLine, which supports HTML, Vue, and Angular in addition to JSX. The old name has been deprecated.
https://prettier.io/blog/2021/09/09/2.4.0.html

How: Edited Prettier config

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #230 (02ab65a) into main (4b01d0f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files          21       21           
  Lines         600      600           
  Branches      228      228           
=======================================
  Hits          380      380           
  Misses        179      179           
  Partials       41       41           
Impacted Files Coverage Δ
src/config/prettierrc.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 57e42d1 into kentcdodds:main Aug 24, 2022
@github-actions
Copy link

🎉 This PR is included in version 12.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds
Copy link
Owner

@all-contributors please add @nickmccurdy for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @nickmccurdy! 🎉

@nickmccurdy nickmccurdy deleted the patch-1 branch August 24, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants