Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rollpkg to other solutions #186

Merged
merged 1 commit into from Dec 20, 2020
Merged

Add Rollpkg to other solutions #186

merged 1 commit into from Dec 20, 2020

Conversation

rafgraph
Copy link
Contributor

What: Add Rollpkg to the Other Solutions section

Why:
Rollpkg is a convention over config build tool to create packages with Rollup and TypeScript. I recently created Rollpkg while converting some packages to TypeScript, and since you're also moving packages to TS I thought you might find it useful.

Rollpkg uses the TS compiler instead of Babel to compile to ES5 (or your desired target), but it also uses babel-plugin-annotate-pure-calls, and I think it should be possible to add support for babel-plugin-macros, or maybe some sort of TypeScript macros? Collaborators welcome.

Checklist:

  • Documentation
  • Tests - N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #186 (5cc914c) into master (6b700e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files          17       17           
  Lines         424      424           
  Branches      162      162           
=======================================
  Hits          363      363           
  Misses         54       54           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b700e6...5cc914c. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎

@kentcdodds kentcdodds merged commit 9e7be24 into kentcdodds:master Dec 20, 2020
@kentcdodds
Copy link
Owner

@all-contributors please add @rafgraph for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @rafgraph! 🎉

@rafgraph
Copy link
Contributor Author

Thanks!

@github-actions
Copy link

🎉 This PR is included in version 7.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants