Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

v7.0.1 leaves processes hanging on Windows #230

Closed
XhmikosR opened this issue Mar 5, 2020 · 1 comment
Closed

v7.0.1 leaves processes hanging on Windows #230

XhmikosR opened this issue Mar 5, 2020 · 1 comment

Comments

@XhmikosR
Copy link

XhmikosR commented Mar 5, 2020

  • cross-env version: 7.0.1
  • node version: 12.16.1
  • npm version: 6.13.4

What you did:

npm run make-fake-data && cross-env REACT_APP_FAKE_API=1 npm run start

What happened:

75963152-aeab7400-5ecd-11ea-9e76-3c6a1b2d6c6f

Reproduction instructions:

Assuming you are on Windows:

git clone https://github.com/pi-hole/web -b development
npm i && npm run start-fake

Then try to ctrl+c the process. One needs to hit ctrl+C twice. If you don't do it twice, then you can check the task manager and you will see node.exe left running


Initially reported in the PR that introduced the issue here. Going back to v7.0.0 works as expected.

@kentcdodds
Copy link
Owner

This has been fixed in 7.0.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants