Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate schema info classes #837

Open
pmantica1 opened this issue May 29, 2020 · 1 comment
Open

Duplicate schema info classes #837

pmantica1 opened this issue May 29, 2020 · 1 comment
Assignees
Milestone

Comments

@pmantica1
Copy link
Contributor

We added the SQLSchemaInfo class without deleting the SQLAlchemySchemaInfo class and they are are almost exact duplicates. We also added the GenericSchemaInfo class without deleting the CommonSchemaInfo class.

@pmantica1
Copy link
Contributor Author

The SQLAlchemySchemaInfo and SQLSchemaInfo are almost identical externally except for the constructor. The SQLAlchemySchemaInfo takes in a schema and type_equivalence_hints and the SQLSchemaInfo takes in a generic_schema_info. If we are shifting toward using generic_schema_info as input, then we might also want to change the function signatures of _create_sql_schema_info, get_sqlalchemy_schema_info and make_sqlalchemy_schema_info. (The fact that we have so many different constructors is a different issue though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants