Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filename's description in the README is wrong #76

Open
maxshuty opened this issue Apr 21, 2021 · 1 comment · May be fixed by #86
Open

filename's description in the README is wrong #76

maxshuty opened this issue Apr 21, 2021 · 1 comment · May be fixed by #86
Assignees
@kempsteven

Comments

@maxshuty
Copy link

maxshuty commented Apr 21, 2021 •
edited

The description in the README for the filename is currently set to the same thing that paginate-elements-by-height is set to. I would put up an MR to update this but I'm unaware of any potential limitations that the filename may have, but presumably it should be something like

Sets the filename of the downloaded PDF

Instead it currently says:

The number inputed will be used to paginate elements, the number will be in px units only.
@kempsteven
Copy link
Owner

Didn't see this one, thanks

@maxshuty maxshuty linked a pull request Jun 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kempsteven kempsteven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating the filename description in the README maxshuty/vue-html2pdf
2 participants
@maxshuty @kempsteven