Updated the examples to use the word response instead of res to avoid… #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO result will be more appropriate instead of response.
… |
|
@agathver |
fast-facts
pushed a commit
to fast-facts/node.bcrypt.js
that referenced
this pull request
Jun 17, 2022
Updated the examples to use the word response instead of res to avoid…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I love this library.
The most common use case of using Bcrypt is to hash a password inside of a REST API. The convention for many of these libraries is to use res to indicate response.
I've seen dozens of developers bewildered and collectively wasting hours of debugging because the parameter res overwrites the existing one and the error message given is not clear about this.
All of this can simply be avoided by changing the example to call is response instead of res. Please consider this change.