New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails on Node.js v12 #715

Closed

BridgeAR opened this issue Apr 5, 2019 · 4 comments

Assignees

BridgeAR commented Apr 5, 2019

A couple fixes landed to make bcrypt compatible with Node.js v12 but it seems like it still fails to build (https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1801/nodes=debian9-64/testReport/junit/(root)/citgm/bcrypt_v3_0_5/).

Refs: nodejs/citgm#701

The text was updated successfully, but these errors were encountered:

richardlau commented Apr 5, 2019

The recent breakage was (intentionally) caused by nodejs/node#27013.

nan needs to be 2.13.2 to pick up nodejs/nan#842:
https://github.com/nodejs/nan/blob/master/CHANGELOG.md

recrsn self-assigned this

Collaborator

recrsn commented Apr 17, 2019

@richardlau v3.0.6 is out with updated nan

richardlau mentioned this issue

lookup: unskip bcrypt for Node.js 12 nodejs/citgm#718

Merged

2 tasks

YasharF commented Aug 11, 2019

Is this still a problem?

Author

BridgeAR commented Aug 11, 2019

@YasharF this should be fixed with 3.0.6.

BridgeAR closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment