Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI is not compatible with tslint.json's rules #70

Open
nelson6e65 opened this issue Aug 15, 2019 · 7 comments
Open

CLI is not compatible with tslint.json's rules #70

nelson6e65 opened this issue Aug 15, 2019 · 7 comments

Comments

@nelson6e65
Copy link

tslint.json

The rules are not sorted alphabetically, only the first level keys. 馃槩

@nelson6e65 nelson6e65 changed the title Compatible with tslint rules CLI is not compatible with tslint.json's rules Aug 15, 2019
@keithamus
Copy link
Owner

Thanks for the issue @nelson6e65, PRs welcome!

@nelson6e65
Copy link
Author

I'll try. Any advise?

@keithamus
Copy link
Owner

The sortSubKey function within this codebase is used to sort the items of a key within the JSON, so adding sortSubKey('rules') would work I believe.

@fisker
Copy link
Collaborator

fisker commented Jan 9, 2020

We should focus on sorting package.json.

@keithamus
Copy link
Owner

Yes perhaps we can extract a lot of the core functionality here and make a new sort-tsconfig package.

@nelson6e65
Copy link
Author

Yes perhaps we can extract a lot of the core functionality here and make a new sort-tsconfig package.

That would be great!

But... have different tools.... Hmm... Maybe split it in internal modules and detect the "format" automatically from filename or and explicit --type.

@nelson6e65
Copy link
Author

Well, tslint becomes deprecated, but still would be nice to sort another .json config files with the same base cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants