Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update globby@10.0.0 to at least 11.0.0 #247

Closed
loynoir opened this issue Mar 20, 2022 · 4 comments · Fixed by #256
Closed

Please update globby@10.0.0 to at least 11.0.0 #247

loynoir opened this issue Mar 20, 2022 · 4 comments · Fixed by #256
Labels

Comments

@loynoir
Copy link

loynoir commented Mar 20, 2022

Brief

sort-package-json@1.54.0 problem located

using globby@10.0.0
https://github.com/keithamus/sort-package-json/blob/v1.54.0/package.json#L77

History

globby@10.0.0 has problem "Including @types/glob in dependencies breaks typescript implementations"

sindresorhus/globby#129

Fixed in "Get rid of glob dependency"
sindresorhus/globby#135

Drop glob and @types/glob dependencies

https://github.com/sindresorhus/globby/commits/v11.0.0

Comparison: package.json

globby@10.0.0
https://github.com/sindresorhus/globby/blob/v10.0.2/package.json#L59

globby@11.0.0
https://github.com/sindresorhus/globby/blob/v11.0.0/package.json#L59

Related

microsoft/TypeScript#48341

@gjgarryuan
Copy link

I am facing the exact same problem.

If you can use npm 8 where overrides is available and you are not using Lerna, you can add the following in the package.json:

{
  ...,
  "overrides": {
    "sort-package-json": {
      "globby": "11.0.0"
    }
  }
}

I verified the above works for plain-old typescript project. However, if you are using Lerna, it is working unexpectedly and I submitted an issue to them here: lerna/lerna#3102

@gjgarryuan
Copy link

There is also another work-around if you cannot use npm 8: https://github.com/rogeriochaves/npm-force-resolutions

@loynoir
Copy link
Author

loynoir commented Apr 3, 2022

@garrychnca

According to pnpm/pnpm#4457

I think, pnpm has fixed, or said prevent, all this kind problem forever, by default.

@github-actions
Copy link

github-actions bot commented May 1, 2022

🎉 This issue has been resolved in version 1.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants