Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS M1: Add sub-dependencies #649

Closed
mohanish2504 opened this issue Dec 24, 2023 · 13 comments
Closed

Mac OS M1: Add sub-dependencies #649

mohanish2504 opened this issue Dec 24, 2023 · 13 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@mohanish2504
Copy link
Contributor

Sqlalchemy has sub dependency to greenlet.

To Reproduce
just poetry install (1.3.2) mac m1 silicon

Expected behavior
Will fail with error

HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out

Desktop (please complete the following information):

  • OS: Macbook M1 pro

Proposed fix:

  • adding greenlet and grpcio to poetry fixes the issue.
@shahargl
Copy link
Member

hey @mohanish2504, can you elaborate a little bit? we do have docker image for M1.
do you run Keep in air-gapped environment?

@mohanish2504
Copy link
Contributor Author

Hey @shahargl what by air-gapped environment?

I was dev docker-compose file and was trying to build on local.

@shahargl
Copy link
Member

like without connectivity to the internet. But I think that if you are not sure - then its not that :P

So you've just ran docker-compose -f docker-compose.dev.yml up and got
HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out
?

@shahargl shahargl self-assigned this Dec 24, 2023
@mohanish2504
Copy link
Contributor Author

Yep.
I have a good network bandwidth.

I first thaught the same but after some digging, I realized there are separate issues for Mac M1 specifically.

references:

Note: even though issues are closed, I was able to reproduce it.

@mohanish2504
Copy link
Contributor Author

mohanish2504 commented Dec 24, 2023

Fixed for me:
greenlet = "^3.0.3" grpcio = "^1.60.0"
Not sure how to distribute while building for m1 and other systems and add dependency during runtime.
I think you must be having an image at your end only?

If you want I can push with a PR.

@shahargl
Copy link
Member

Super weird. I've M1 also and I'm trying to reproduce the problem. Do you want to open PR with the solution that have worked for you? I'll check it and merge it.

@mohanish2504
Copy link
Contributor Author

okay sure.

@shahargl
Copy link
Member

@mohanish2504 btw are you working with Keep now?

@shahargl
Copy link
Member

while working the reproduce it I found another bug (?) which fixed by this #650

@mohanish2504
Copy link
Contributor Author

@shahargl it's indeed the poor connectivity. It seems the bandwidth was fluctuating quite a bit.

Everything worked fine as soon as I moved back to my home network, was out 😅.
It was 10-12 Mbps constant though.

You can mark this as closed.

@mohanish2504
Copy link
Contributor Author

I was able to reproduce the issue you fixed at #650

@mohanish2504
Copy link
Contributor Author

@mohanish2504 btw are you working with Keep now?

Yes, definitely.
Always looking forward to learn from OSS projects 😃.

@talboren talboren added the wontfix This will not be worked on label Dec 25, 2023
@talboren
Copy link
Member

Closing this issue since it seems like it was just some internet connectivity problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants