Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package pkg/maintainer/spv should not depend on btcd directly #3677

Open
lukasz-zimnoch opened this issue Jul 7, 2023 · 0 comments
Open

Package pkg/maintainer/spv should not depend on btcd directly #3677

lukasz-zimnoch opened this issue Jul 7, 2023 · 0 comments
Labels
📟 client

Comments

@lukasz-zimnoch
Copy link
Member

The btcd package is a 3rd party dependency meant to be used only within pkg/bitcoin package which isolates it from the client code. However, pkg/maintainer/spv depends on btcd directly which makes it leak beyond pkg/bitcoin. We should fix that and ensure btcd is not used directly by any other package except pkg/bitcoin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📟 client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukasz-zimnoch