Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert connected network type on client start #3602

Open
nkuba opened this issue Jun 5, 2023 · 0 comments
Open

Assert connected network type on client start #3602

nkuba opened this issue Jun 5, 2023 · 0 comments

Comments

@nkuba
Copy link
Member

nkuba commented Jun 5, 2023 •
edited

This check is based on the flags declared by the user in config. Could we add two checks?

  1. If Ethereum is testnet, then Bitcoin also has to be testnet, If Ethereum is mainneg then Bitcoin also has to be mainnet.
  2. That the actual Ethereum and Electrum servers the node is connected to supports the desired networks?
    We have a similar solution in the Electrum TS library: https://github.com/keep-network/tbtc-v2/blob/7f48d6362f8bfc9a2931c4087e5eba28efee5370/typescript/src/electrum.ts#L208-L224

Originally posted by @nkuba in #3596 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkuba