Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep-client generates new preparams at each restart #3537

Open
thevops opened this issue Apr 25, 2023 · 1 comment
Open

Keep-client generates new preparams at each restart #3537

thevops opened this issue Apr 25, 2023 · 1 comment
Labels
📟 client 👩‍⚕️triage Needs further attention and categorization

Comments

@thevops
Copy link
Contributor

thevops commented Apr 25, 2023

As I understand, keep-client generates preparams up to the default value which is 1000.
But I noticed that keep-client generates also one preparam at each restart of the container.
Currently, I have:

/ $ ls -1 /storage/work/tbtc/preparams/ | wc -l
1013

My environment

Chain: goerli (I didn't check this issue on mainnet yet)

Docker image: us-docker.pkg.dev/keep-test-f3e0/public/keep-client (from: https://docs.threshold.network/staking-and-running-a-node/goerli-testnet-staking/testnet-tbtc-v2-node-setup#docker-launch-script)

Additional configuration:

KeyGenerationConcurrency: 1
PreParamsGenerationConcurrency: 1

--- EDIT ---

I've also noticed that these redundant preparams over 1000 are not included in the Prometheus metric tbtc_pre_params_count. That metric shows 1000 even if there are more preparams.

@thevops
Copy link
Contributor Author

thevops commented May 10, 2023

I checked this on mainnet also, and it seems that the same issue exists.
I have more than 1000 preparams depending on the number of restarts.

@lukasz-zimnoch lukasz-zimnoch added 📟 client 👩‍⚕️triage Needs further attention and categorization labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📟 client 👩‍⚕️triage Needs further attention and categorization
Projects
None yet
Development

No branches or pull requests

2 participants