Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKG improvements to the challenge mechanism #3462

Open
pdyraga opened this issue Jan 4, 2023 · 0 comments
Open

DKG improvements to the challenge mechanism #3462

pdyraga opened this issue Jan 4, 2023 · 0 comments

Comments

@pdyraga
Copy link
Member

pdyraga commented Jan 4, 2023

There are two problems with the existing challenge mechanism:

  1. In case we run the challenge loop in executeDkgValidation one more time, we do not know if the result is still the one most recently submitted to the chain. It could happen that the challenge was mined and another result got submitted later. Before we execute this loop again, we should check the result - probably reading it from the last event.
  2. The log saying invalid DKG result still not challenged; retrying may not always be true. We could have another result submitted in the meantime and challenged. I think we should remove this log from the end of the loop and move it to the beginning of the loop after we check that the result we are challenging is the last one submitted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant