Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pluggy depdendency version (<1.4) - Preventing upgrade of Pytest 8.1 that requires pluggy >=1.4 #3763

Closed
rxm7706 opened this issue Mar 31, 2024 · 6 comments

Comments

@rxm7706
Copy link
Contributor

rxm7706 commented Mar 31, 2024

Description

Kedro currently pins Pluggy to >=1.0,<1.4
#3574
which was pinned because it broke tests
#3552

This is currently preventing upgrade of pytest - as pytest 8.1 requires pluggy >=1.4,<2.0

Context

Steps to Reproduce

Expected Result

Actual Result

-- If you received an error, place it here.
-- Separate them if you have more than one.

Your Environment

  • Kedro version used (pip show kedro or kedro -V):
  • Python version used (python -V):
  • Operating system and version:
@noklam
Copy link
Contributor

noklam commented Apr 8, 2024

Created a draft PR to see what breaks pluggy. Curious if there is any goodies for pytest 8.0? We are still on <8.0.
#3786

@noklam noklam linked a pull request Apr 8, 2024 that will close this issue
7 tasks
@antonymilne
Copy link
Contributor

Just to add another data point here. I was also tripped up by this when running vizro tests which use pytest and have kedro as a dependency.

@noklam
Copy link
Contributor

noklam commented Apr 29, 2024

@antonymilne the dependency is removed already. I think we may have accidentally pin pytest as core dependencies in some version, it should be test dependencies only.

@antonymilne
Copy link
Contributor

antonymilne commented Apr 30, 2024

@noklam the problem is with the kedro's dependence onpluggy, not the dependency on pytest. But it seems to be fixed here 🙂 #3840

@noklam
Copy link
Contributor

noklam commented Apr 30, 2024

@antonymilne Sorry I mean to say pluggy but yeah the pin was removed.

Before the new pluggy release it was necessary to pin it as test dependencies as it breaks certain API that we mock

@noklam
Copy link
Contributor

noklam commented May 20, 2024

Fixed by #3840 already

@noklam noklam closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants