Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up setuptools and wheel requirements to align with PEP-518 #1559

Closed
noklam opened this issue May 19, 2022 · 7 comments
Closed

Clean up setuptools and wheel requirements to align with PEP-518 #1559

noklam opened this issue May 19, 2022 · 7 comments
Assignees

Comments

@noklam
Copy link
Contributor

noklam commented May 19, 2022

We've got "setuptools>=38.0" and wheel requirements in various other places in the repo (just do a Ctrl+F to see them). Does this mean we can remove them from there?

If yes then that would be nice but a bit of a bigger change, so probably worth doing in a separate PR.

Originally posted by @AntonyMilneQB in #1542 (comment)

@noklam noklam self-assigned this May 19, 2022
@antonymilne
Copy link
Contributor

We will reassess how much effort this is and exactly what's involved once we've split all our test requirements etc. following the creation of kedro-datasets. If we remove our requirements for pip-tools then maybe we can remove our dependency on setuptools altogether.

@merelcht merelcht added this to the Improve DevOps and DevSetup milestone Jan 10, 2023
@astrojuanlu
Copy link
Member

When #2152 is addressed, I guess the build requirements would only be specified in the PEP 518 [build-system] table of pyproject.toml.

@merelcht
Copy link
Member

@astrojuanlu Is there any more work that needs to be done here, or is it completed with #2152 as you commented above?

@astrojuanlu
Copy link
Member

I think we should be able to safely remove them from scripts and files used for development, namely:

kedro/Makefile

Lines 10 to 11 in 7dcb60c

install-pip-setuptools:
pip install -U "pip>=21.2" "setuptools>=65.5.1" wheel

"setuptools>=65.5.1",
"wheel",

setuptools>=65.5.1

setuptools>=65.5.1

However, there are other mentions related to kedro package, (which will require addressing #2413 first), and maybe the starters (#2280).

@merelcht
Copy link
Member

Okay cool, thanks for the clarification! In that case let's get #2413 in the next sprint and complete that first.

@lrcouto lrcouto self-assigned this Aug 14, 2023
@astrojuanlu
Copy link
Member

To make sure I understand, this issue is about the Kedro CI, and #2350 is about the Kedro runtime dependencies, right? (The latter being a bit more difficult because of #2350 (comment))

@astrojuanlu
Copy link
Member

Closed in #2927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants